[utils] add update-verify-tests.py #85351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This script is used to automatically update test cases using -verify in clang's test suite. Swift also has a similar -verify test functionality, and while it can automatically fix some of them using -verify-apply-all, this functionality only updates existing checks - it doesn't add or remove any, and it doesn't handle newer and more complex things like expected-expansion. Handling that type of complexity feels out of scope to embed in the compiler, so let's copy clang's approach. This commit adds this script as is from clang. It doesn't work at all for Swift in its current form, as the output from Swift's -verify is formatted differently than in clang. This will be fixed in subsequent commits. This could have been done by adapting the script as-is in the llvm-project repository (since it only exists in the Swift fork, not upstream), but tests using swift-frontend would have to reside in the swift repo, and modifying a script in one repo with tests in a different repo sounds like a recipe for endless CI issues.
This ports clang's test suite for update-verify-tests from C to Swift, and adjusts update-verify-tests as needed. The main differences are the Swift -verify output format being quite different, as well as Swift's '-verify-additional-prefix foo' working differently than clang's '-verify=foo'.
This updates the documentation to reflect the Swift port of this script, rather than the original clang version.
Member Author
| @swift-ci please smoke test |
j-hui approved these changes Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This adds clang's update-verify-tests.py, which can be used to automatically update failing tests that use
-verify, and makes adjustments as necessary where clang and Swift differ.