[autolink-extract] Update deduplication list for new Foundation, Testing, and WASI platform #84784
Conversation
…ing, and WASI platform We now have several new runtime libraries in the toolchain but they are not listed in the autolink deduplication list. This can lead to an excessive memory footprint when linking on platforms that use autolink-extract. See swiftlang#58380
| @swift-ci smoke test |
kateinoigakukun requested review from finagolfin and artemcm and removed request for MaxDesiatov and etcwilde 
MaxDesiatov added autolinking swift-autolink-extract 
| "-lFoundationInternationalization", | ||
| "-lFoundationNetworking", | ||
| "-lFoundationXML", | ||
| "-l_CFXMLInterface", |
There was a problem hiding this comment.
This is a static-only CoreFoundation library: I thought we weren't supposed to publicly link these?
There was a problem hiding this comment.
Good point, yes. They are static-only libraries and we static-link everything. They are not supposed to be imported at code, so they don't have their corresponding .swiftmodule but we still ship their archives. So those link options are embedded in the client of those private modules (in this case, FoundationXML.swiftmodule) through -public-autolink-library
https://github.com/swiftlang/swift-corelibs-foundation/blob/ec675206c8cd939fbd4783421ea07954dcb5e175/Sources/FoundationXML/CMakeLists.txt#L33-L47
| "-lFoundationNetworking", | ||
| "-lFoundationXML", | ||
| "-l_CFXMLInterface", | ||
| "-l_FoundationCShims", |
There was a problem hiding this comment.
Another static-only library, bit taken aback since the first time I'm seeing these listed here, sure you need this?
| "-lFoundationXML", | ||
| "-l_CFXMLInterface", | ||
| "-l_FoundationCShims", | ||
| "-l_FoundationCollections", |
There was a problem hiding this comment.
Same here, static-only, I guess you're static linking the runtime libraries much more for Wasm binaries?
| "-lXCTest", | ||
| // swift-testing libraries | ||
| "-l_TestingInternals", | ||
| "-l_TestDiscovery", |
There was a problem hiding this comment.
I don't see either of these in the linux SDK, Wasm only?
There was a problem hiding this comment.
They are also static-only libraries, installed only when building swift-testing with BUILD_SHARED_LIBS=OFF.
https://github.com/swiftlang/swift-testing/blob/fa1e095b316b9925dd5cc7fafc5d67825a07cd52/Sources/_TestingInternals/CMakeLists.txt#L31
Other platform toolchains/SDKs don't have it because they always build it as shared libraries.
We now have several new runtime libraries in the toolchain but they are not listed in the autolink deduplication list. This can lead to an excessive memory footprint when linking on platforms that use autolink-extract.
See #58380
As a data point, this change reduced the memory footprint of our wasm-ld process from 33.34 GiB → 2.22 GiB and link time from 46.4 s → 1.4 s.