CMake: Glibc Overlay #84737
Open
CMake: Glibc Overlay #84737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Platform availability is an Apple concept because Swift is shipped as part of the OS. It doesn't make sense to check or to warn on other platforms. Only checking and setting it for Apple platforms.
etcwilde requested review from compnerd, edymtt and justice-adams-apple as code owners | @swift-ci please smoke test |
compnerd approved these changes Oct 7, 2025
etcwilde force-pushed the ewilde/runtimes-linux-glibc-overlay branch 2 times, most recently from ca572b0 to 5369578 Compare | @swift-ci please smoke test |
Explicit module builds crash the compiler when building the glibc overlay library. The crash occurs in the Swift driver dependency scanner. It appears to be related to vfs overlays, modulemaps, injected header files, and explicit module builds. This is odd though because the Android builds also have this combination, but work.
Adding a new glibc overlay for Linux builds. We will eventually need one for Musl, and if someone really wants to, LLVM and cosmopolitan libcs are also out there.
etcwilde force-pushed the ewilde/runtimes-linux-glibc-overlay branch from 5369578 to 59ade4c Compare | @swift-ci please smoke test |
edymtt reviewed Oct 7, 2025
| Swift_MODULE_NAME Glibc) | ||
| | ||
| target_compile_options(swiftGlibc PRIVATE | ||
| "SHELL:-Xcc -fno-omit-frame-pointer" |
There was a problem hiding this comment.
Should we ensure these flags are only set when compiling for Swift? Or are we sure we will not be adding other non Swift files to this target?
| "SHELL:-Xfrontend -empty-abi-descriptor" | ||
| "SHELL:-Xfrontend -prespecialize-generic-metadata" | ||
| "SHELL:-Xfrontend -require-explicit-availability=ignore" | ||
| "SHELL:-library-level api") |
There was a problem hiding this comment.
Unless I'm missing context, I think we want to install this library
Suggested change
| "SHELL:-library-level api") | |
| "SHELL:-library-level api") | |
| install(TARGETS swiftGlibc | |
| EXPORT SwiftOverlayTargets | |
| ARCHIVE DESTINATION "${SwiftOverlay_INSTALL_LIBDIR}" | |
| LIBRARY DESTINATION "${SwiftOverlay_INSTALL_LIBDIR}" | |
| RUNTIME DESTINATION "${CMAKE_INSTALL_BINDIR}") | |
| emit_swift_interface(swiftGlibc) | |
| install_swift_interface(swiftGlibc) | |
| embed_manifest(swiftGlibc) |
| @swift-ci please smoke test Linux Platform |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adding a Glibc overlay for Linux. As part of this, I bumped the stdlib version override to only apply to Apple platforms since that's the only place where those have meaning. This way we don't see warnings about not recognizing the other platforms.