Skip to content

WIP retain/release emit-into-client #84159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 46 commits into from
Closed

WIP retain/release emit-into-client #84159

wants to merge 46 commits into from
+713 −40

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented Sep 8, 2025

No description provided.

@mikeash
Copy link
Contributor Author

mikeash commented Sep 12, 2025

@swift-ci please Apple Silicon benchmark
2 similar comments
@mikeash
Copy link
Contributor Author

mikeash commented Sep 13, 2025

@swift-ci please Apple Silicon benchmark
@mikeash
Copy link
Contributor Author

mikeash commented Sep 15, 2025

@swift-ci please Apple Silicon benchmark
@mikeash
Copy link
Contributor Author

mikeash commented Sep 22, 2025

@swift-ci please test
@mikeash
Copy link
Contributor Author

mikeash commented Sep 23, 2025

@swift-ci please Apple Silicon benchmark
9 similar comments
@mikeash
Copy link
Contributor Author

mikeash commented Sep 24, 2025

@swift-ci please Apple Silicon benchmark
@mikeash
Copy link
Contributor Author

mikeash commented Sep 25, 2025

@swift-ci please Apple Silicon benchmark
@mikeash
Copy link
Contributor Author

mikeash commented Sep 26, 2025

@swift-ci please Apple Silicon benchmark
@mikeash
Copy link
Contributor Author

mikeash commented Sep 29, 2025

@swift-ci please Apple Silicon benchmark
@mikeash
Copy link
Contributor Author

mikeash commented Oct 1, 2025

@swift-ci please Apple Silicon benchmark
@mikeash
Copy link
Contributor Author

mikeash commented Oct 2, 2025

@swift-ci please Apple Silicon benchmark
@mikeash
Copy link
Contributor Author

mikeash commented Oct 2, 2025

@swift-ci please Apple Silicon benchmark
@mikeash
Copy link
Contributor Author

mikeash commented Oct 3, 2025

@swift-ci please Apple Silicon benchmark
@mikeash
Copy link
Contributor Author

mikeash commented Oct 6, 2025

@swift-ci please Apple Silicon benchmark
@mikeash mikeash force-pushed the inline-rr branch 2 times, most recently from 68f54fb to 12aad93 Compare October 6, 2025 23:15
@mikeash
Copy link
Contributor Author

mikeash commented Oct 6, 2025

@swift-ci please test
mikeash added 12 commits October 8, 2025 13:49
mikeash added 14 commits October 8, 2025 13:49
@mikeash
Add alignment directive to functions.
f3e5165
@mikeash
Inlined -> Client in LLVMARCOpts.h.
961023f
@mikeash
Add Client versions of bridgeObjectRR.
2a3c58a
@mikeash
Early out on tagged pointers in bridgeObjectRR.
c24fb77
@mikeash
Switch from __ARM_FEATURE_PAUTH to __has_feature(ptrauth_calls) to av…
d29ff46 
…oid generating ptrauth instructions in ARM64 macOS. Make the tagged pointer early-out ret instruction come immediately after the test instead of later on. Add a non-local label to the objc_RR paths so they're more identifiable.
@mikeash
Disable clientRR in JIT mode.
4487e56
@mikeash
Make bridgeObjectRetainClient return the original unmasked value.
9805175
@mikeash
Put the slowpath mask in a special section.
59ffb8c
@mikeash
Add 'preservemost' aliases for swift_retain/release. Use weak definit…
ae3afdf 
…ions to bring a wrapper for older runtimes that adapts the calling convention.
@mikeash
Use raw strings for asm in HeapObject.cpp.
44385ac
@mikeash
Add an option to disable client retain/release.
d857de4
@mikeash
Fix alignment of slowpath mask.
9a9e6c4
@mikeash
Mask off spare bits in bridgeObjectReleaseClient in the not-OBJC_INTE…
c09846b 
…ROP case too.
@mikeash
Limit ClientRetainRelease to Darwin for the moment. We need more chan…
4d77e3b 
…ges to play nicely with the assembler elsewhere.
@mikeash
Copy link
Contributor Author

mikeash commented Oct 8, 2025

@swift-ci please test
@mikeash
Copy link
Contributor Author

mikeash commented Oct 9, 2025

@swift-ci please test
1 similar comment
@mikeash
Copy link
Contributor Author

mikeash commented Oct 9, 2025

@swift-ci please test
@mikeash
Copy link
Contributor Author

mikeash commented Oct 9, 2025

@swift-ci please test
@mikeash
Copy link
Contributor Author

mikeash commented Oct 10, 2025

@swift-ci please test
@mikeash
Copy link
Contributor Author

mikeash commented Oct 13, 2025

@swift-ci please test macos platform
@mikeash
Copy link
Contributor Author

mikeash commented Oct 21, 2025

I've consolidated this into a clean non-draft PR here: #85044
@mikeash mikeash closed this Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@mikeash