[stdlib] Allow metatype comparisons to work with outdated compilers #80859
+11 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member Author
| I haven't even tried building this locally, but let's roll the dice @swift-ci test |
lorentey requested review from Azoy, glessard and tshortli and removed request for DougGregor 
tshortli reviewed Apr 16, 2025
DougGregor reviewed Apr 16, 2025
Add a new language feature to avoid the stdlib’s swiftinterface becoming unintelligible to outdated compiler builds due to the generalization of Builtin.is_same_metatype. rdar://149396721
lorentey force-pushed the is_same_metatype_condfail branch from ad5a81f to 0c406b8 Compare Member Author
| Well that was silly; apologies for my brain hiccup. The amended version should be closer to what we need. |
Member Author
| @swift-ci test |
tshortli approved these changes Apr 16, 2025
lorentey changed the title Member Author
| @swift-ci smoke test linux |
Member Author
| @swift-ci test |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add a new language feature to avoid the stdlib’s swiftinterface becoming unintelligible to older compilers due to the generalization of Builtin.is_same_metatype.
Restore the original version of the
==operator so that metatypes can continue to be compared even if the generalized version ends up getting omitted.rdar://149396721