Skip to content

Updated note in case of concurrency #75232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Updated note in case of concurrency #75232

wants to merge 2 commits into from

Conversation

@adityaanand176
Copy link

@adityaanand176 adityaanand176 commented Jul 14, 2024

Resolves: #74751
@adityaanand176 adityaanand176 requested a review from ktoso as a code owner July 14, 2024 13:35
@ktoso
Copy link
Contributor

ktoso commented Jul 15, 2024

you'll have to actually change implementation, not just the assertion.
ktoso
ktoso requested changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't just change the test without changing implementation -- look for where the note is emitted and you'll have to change that
@AnthonyLatsis
Copy link
Collaborator

AnthonyLatsis commented Jul 20, 2024

This issue was resolved in #75235.
@ktoso ktoso closed this Jul 22, 2024
@AnthonyLatsis
Copy link
Collaborator

AnthonyLatsis commented Jul 22, 2024

@adityaanand176 Next time please ask us to assign you to the issue to avoid conflicts. See: How do I pick something to work on?
@adityaanand176
Copy link
Author

adityaanand176 commented Jul 23, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@adityaanand176 @ktoso @AnthonyLatsis