Skip to content

Conversation

@vidhupv
Copy link
Contributor

@vidhupv vidhupv commented Jul 12, 2024

Resolves #75109 .

@vidhupv vidhupv changed the title Updates screenshot for HowtoGuides for First PR Updates screenshot for HowtoGuides of First PR Jul 12, 2024
@AnthonyLatsis
Copy link
Collaborator

Ok, let’s go with this PR then.

Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lost the screenshot along the way?

@AnthonyLatsis AnthonyLatsis mentioned this pull request Jul 13, 2024
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the screenshot and re-request the review so this doesn't get lost.

@vidhupv
Copy link
Contributor Author

vidhupv commented Jul 18, 2024

Hi @AnthonyLatsis @xedin , I thought the screenshot was added. Will do so soon.

@AnthonyLatsis
Copy link
Collaborator

@vidhupv Need help?

@AnthonyLatsis
Copy link
Collaborator

@vidhupv Could you crop the screenshot so that:

  • The left & right margins match.
  • The orange segment next to the top left corner is not visible?

Also, please consider rewording the commit title to be more specific. For example: Update screenshot in FirstPullRequest.md.


git commit --amend to squash staged changes into the last commit and edit its message, then force push.

@AnthonyLatsis
Copy link
Collaborator

AnthonyLatsis commented Dec 24, 2024

@vidhupv Are you still working on this?

@vidhupv
Copy link
Contributor Author

vidhupv commented Dec 24, 2024

@AnthonyLatsis Hi, yes. Sorry I was busy with some stuff and was planning to do over the break. Will get on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants