[Sema] Diagnose ambiguous for RValue to LValue - pick overload choice that is settable #74236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| @swift-ci Please smoke test. |
xedin requested changes Jun 9, 2024
Contributor
xedin left a comment
xedin left a comment There was a problem hiding this comment.
I think it would be better to reflect this in the score at the point where the fix is recorded instead of having to retroactively rank the fixes, this would mean that we can prune solutions more effectively.
Contributor
| Thanks for all the work you have done recently, I will try to take a look at other PRs asap! |
Contributor Author
Makes sense! I'll look at that. |
gregomni force-pushed the rvalue-ambiguous branch from 724d6e6 to b07a2aa Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
With multiple overload choices, TreatRValueAsLValue used to just pick the first solution. We get better diagnostics if we pick a solution where the chosen VarDecl is settable, if there is one.
I.e. if you conform to two protocols with same-named property, one of which is
{get}and the other is{get set}and both possibilities end up with the same fix in the same location, it isn't much help to use the "it's a get-only property" choice.Resolves #46265