[Caching] Embed bridging header in binary module correctly when caching #72804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cachemeifyoucan requested review from egorzhdan, hborla, hyp, slavapestov, xedin and zoecarver as code owners 
| Need clang change here: swiftlang/llvm-project#8531 |
cachemeifyoucan force-pushed the eng/PR-125719747 branch from 38bc605 to 94d8004 Compare | Please test with following pull request: @swift-ci please smoke test |
| Please test with following pull request: @swift-ci please smoke test linux platform |
artemcm approved these changes Apr 12, 2024
When caching is enabled with include-tree, the bridging header PCH is created from the include tree directly. Setup the rewriter correctly when embedding the bridging header into swift binary module. rdar://125719747
The binary module built from a CAS build will have the embeded bridging header info with 0 modTime. Allow a regular build to import such a module with the same behavior as if the module is built from a regular build. rdar://126221616
cachemeifyoucan force-pushed the eng/PR-125719747 branch from 94d8004 to e654e37 Compare | @swift-ci please smoke test |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When caching is enabled with include-tree, the bridging header PCH is created from the include tree directly. Setup the rewriter correctly when embedding the bridging header into swift binary module.
rdar://125719747