Skip to content

Conversation

@compnerd
Copy link
Member

This allows us to build swift-format with dynamic linking against the
toolchain build of the swift-syntax and swift-argument-parser packages.
Wire up the swift-markdown build and hoist the swift-format build prior
to sourcekit-lsp. This sets us up for supporting swift-format based
formatting in the LSP.

@compnerd
Copy link
Member Author

@compnerd
Copy link
Member Author

@compnerd
Copy link
Member Author

@compnerd
Copy link
Member Author

@compnerd compnerd requested a review from a team as a code owner January 26, 2024 19:06
@compnerd
Copy link
Member Author

@compnerd
Copy link
Member Author

Please test with following PRs:
swiftlang/swift-markdown#141
swiftlang/swift-format#677
swiftlang/swift-installer-scripts#271

@swift-ci please smoke test Linux platform

@compnerd
Copy link
Member Author

Please test with following PRs:
swiftlang/swift-markdown#141
swiftlang/swift-format#677
swiftlang/swift-installer-scripts#271

@swift-ci please smoke test macOS platform

@compnerd
Copy link
Member Author

@compnerd
Copy link
Member Author

@compnerd
Copy link
Member Author

@compnerd
Copy link
Member Author

Please test with following PRs:
swiftlang/swift-markdown#141
swiftlang/swift-format#677
swiftlang/swift-installer-scripts#271

@swift-ci please build toolchain Windows platform

@compnerd
Copy link
Member Author

Please test with following PRs:
swiftlang/swift-markdown#141
swiftlang/swift-format#677
swiftlang/swift-installer-scripts#271

@swift-ci please build toolchain macOS platform

@compnerd
Copy link
Member Author

Please test with following PRs:
swiftlang/swift-markdown#141
swiftlang/swift-format#677
swiftlang/swift-installer-scripts#271

@swift-ci please build toolchain Windows platform

This allows us to build swift-format with dynamic linking against the toolchain build of the swift-syntax and swift-argument-parser packages. Wire up the swift-markdown build and hoist the swift-format build prior to sourcekit-lsp. This sets us up for supporting swift-format based formatting in the LSP.
@compnerd
Copy link
Member Author

@compnerd
Copy link
Member Author

@compnerd
Copy link
Member Author

Verified that the generated installer works, the installed toolchain passes a smoke test. Additionally, verified that swift format continues to function. As a side effect, the installer is now <500 MB again after reaching ~600MB.

@compnerd compnerd merged commit 0dc8fbd into swiftlang:main Jan 28, 2024
@compnerd compnerd deleted the format branch January 28, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants