Un-deprecate _StringGuts._isContiguousASCII #70726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| @swift-ci please smoke test |
parkera approved these changes Jan 4, 2024
Member
| It would probably be a good idea to fix the implementation; at the very least, it should handle the small string case. |
Contributor
| Given this is already in use across Foundation on all platforms, I'm ok with splitting up this no-op change (to make building swift-foundation not emit a few hundred warnings) from fixing the behavior. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This property is used as an implementation detail from within swift-corelibs-foundation and the new swift-foundation repo. Since it is deprecated, it produces numerous warnings when building these projects despite this being a valid use case within Foundation. Rather than avoid performance improvements to "silence" the warning (by not using this property) or dealing with large amounts of warnings, we should just un-deprecate this property since it is already underscored indicating it is not for stable/public use. We can still find a better public API for this in the future that we can migrate Foundation to when it is ready.