Allow enabling embedded Swift without WMO when not generating SIL #70612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| swiftlang/swift-driver#1513 |
kubamracek requested review from MaxDesiatov, ahoppen, bnbarham, eeckstein, kubamracek, phausler, rauhul and zoecarver 
| I'll defer to @kubamracek about correctness, but I'm very thankful to see improvements on this front :) |
| Yeah, this is definitely one part, thanks @owenv 🙇! Mind cherry-picking it too? |
:O |
owenv force-pushed the owenv/embedded-typecheck-without-wmo branch from aaa2085 to cd13467 Compare 
bnbarham approved these changes Jul 15, 2024
| @swift-ci please smoke test Linux |
| @swift-ci please smoke test macOS |
owenv force-pushed the owenv/embedded-typecheck-without-wmo branch from cd13467 to 765deb1 Compare | @swift-ci please smoke test |
owenv force-pushed the owenv/embedded-typecheck-without-wmo branch from 765deb1 to f2f5384 Compare | @swift-ci please smoke test |
This allows modes like -index-file to work the same way they do when not using embedded Swift
owenv force-pushed the owenv/embedded-typecheck-without-wmo branch from f2f5384 to 5490b44 Compare | @swift-ci please smoke test |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This allows modes like -index-file to work the same way they do when not using embedded Swift