[Caching] Encoding cache key for input file with index instead of path #70384
Conversation
| @swift-ci please smoke test |
cachemeifyoucan force-pushed the eng/PR-119387650 branch from 67b8cd5 to 638f362 Compare | @swift-ci please smoke test |
| @swift-ci please smoke test |
| @swift-ci please smoke test windows platform |
| ping |
lib/Option/features.json Outdated
There was a problem hiding this comment.
As a result of swift scan API change, rename the feature in JSON file to avoid version confusion between swift-driver and libSwiftScan.
Should we embed a version number into the dictionary instead of changing the string? That would make it more obvious which string is the new vs. old API.
Alternatively, could you just dlsym the new API and use it when available? That's what we've typically done for libclang
There was a problem hiding this comment.
I removed the dlsym check in swiftDriver because it is getting bigger and bigger. Want to take this as a last chance to reset the feature before start compatibility support as I don't want to keep both code paths to support old and new API in swift driver.
There was a problem hiding this comment.
Any strong opinion going either way?
There was a problem hiding this comment.
I don't feel strongly enough about this to block the change. If this is the last time we need to make an incompatible API change it's fine.
There was a problem hiding this comment.
Yes, one last time. Thanks!
Avoid path encoding difference (for example, real_path vs. path from symlink) by eliminating the path from cache key. Cache key is now encoded with the index of the input file from all the input files from the command-line, reguardless if those inputs will produce output or not. This is to ensure stable ordering even the batching is different. Add a new cache computation API that is preferred for using input index directly. Old API for cache key is deprecated but still updated to fallback to real_path comparsion if needed. As a result of swift scan API change, rename the feature in JSON file to avoid version confusion between swift-driver and libSwiftScan. rdar://119387650
cachemeifyoucan force-pushed the eng/PR-119387650 branch from 638f362 to 76bde39 Compare | @swift-ci please smoke test |
| ping |
2 participants
Avoid path encoding difference (for example, real_path vs. path from symlink) by eliminating the path from cache key. Cache key is now encoded with the index of the input file from all the input files from the command-line, reguardless if those inputs will produce output or not. This is to ensure stable ordering even the batching is different.
Add a new cache computation API that is preferred for using input index directly. Old API for cache key is deprecated but still updated to fallback to real_path comparsion if needed.
As a result of swift scan API change, rename the feature in JSON file to avoid version confusion between swift-driver and libSwiftScan.
rdar://119387650