[libSwiftScan][Caching] Add async download API #69934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add a new async download API from CASID. This helps build system better schedule the job/remove duplicated downloads, than using an opaque cached_output handle.
| @swift-ci please smoke test |
| ping |
artemcm approved these changes Nov 28, 2023
| /// Asynchronously visits the graph of the object node to ensure it's fully | ||
| /// materialized. | ||
| class AsyncObjectLoader | ||
| : public std::enable_shared_from_this<AsyncObjectLoader> { |
There was a problem hiding this comment.
I didn't know about this, neat.
| Will we test this from the |
It is wrapped into Swift APIs in swift-driver for build system. Now I am mostly implemented the build system, I can back port some of the use cases into swift-driver tests, yes. |
| Test for new API added here: swiftlang/swift-driver#1491 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add a new async download API from CASID. This helps build system better schedule the job/remove duplicated downloads, than using an opaque cached_output handle.