Update build-windows-toolchain.bat #69190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Update the toolchain build rules to allow us to package the VCRuntime dependency into the installer. This avoids the VS dependency in the case that we are cross-compiling to a non-Windows platform.
| Please build with following PRs: @swift-ci please build toolchain Windows platform |
| @swift-ci please test |
| @swift-ci please test Linux platform |
MarSe32m reviewed Oct 15, 2023
compnerd commented Oct 16, 2023
Co-authored-by: Martin <sebastian.toivonen@gmail.com>
| Please build with following PRs: @swift-ci please build toolchain Windows platform |
| Please build with following PRs: @swift-ci please test |
shahmishal approved these changes Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Update the toolchain build rules to allow us to package the VCRuntime dependency into the installer. This avoids the VS dependency in the case that we are cross-compiling to a non-Windows platform.