[CompilerCaching] Path Remapping for canonicalization #68684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cachemeifyoucan requested review from akyrtzi, benlangmuir and jansvoboda11 cachemeifyoucan requested review from artemcm, egorzhdan, hborla, hyp, slavapestov, tshortli, xedin and zoecarver as code owners 
| @swift-ci please smoke test |
cachemeifyoucan force-pushed the eng/PR-path-remapping branch from 22f8d5a to 80a8e87 Compare | @swift-ci please test |
| @swift-ci please smoke test |
artemcm reviewed Sep 25, 2023
artemcm approved these changes Sep 25, 2023
cachemeifyoucan force-pushed the eng/PR-path-remapping branch from 80a8e87 to 6f5aa22 Compare | Rebase after merge conflict. @swift-ci please smoke test |
Allow DependencyScanner to canonicalize path using a prefix map. When option `-scanner-prefix-map` option is used, dependency scanner will remap all the input paths in following: * all the paths in the CAS file system or clang include tree * all the paths related to input on the command-line returned by scanner This allows all the input paths to be canonicalized so cache key can be computed reguardless of the exact on disk path. The sourceFile field is not remapped so build system can track the exact file as on the local file system.
Teach CachedDiagnosticsProcessor to replay diagnostics for all consumers with a different path using a path prefix map. This allows diagnostics to be replayed for the actual path on disk after the scanner canonicalized the path for compilation.
cachemeifyoucan force-pushed the eng/PR-path-remapping branch from 6f5aa22 to 5be305e Compare | @swift-ci please smoke test |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Teach dependency scanner to canonicalize the path for better cache hit and also teach swift-frontend to restore the path to the actual on disk path after canonicalization.