[Serialization] Enable deserialization safety by default #63116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rdar://99495048
Contributor Author
| @swift-ci Please smoke test |
bnbarham approved these changes Jan 19, 2023
Both of these IRGen tests expect to see internal details from resilient modules at build time. Deserialization safety hides that information, let's disable it to preserve the desired behavior.
Contributor Author
| Disabled deserialization safety in two tests expecting to read internal details. @swift-ci Please smoke test |
Contributor Author
| @swift-ci Please smoke test |
1 similar comment
Contributor Author
| @swift-ci Please smoke test |
Contributor Author
| @swift-ci Please smoke test Linux |
Contributor Author
| @swift-ci Please smoke test macOS |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The main deserialization safety logic was completed with #63096. This PR simply turns it on by default.
rdar://99495048