- Notifications
You must be signed in to change notification settings - Fork 10.6k
Bump cmake version in GettingStarted.md #62152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 3.21.3 worked for me the other day. Do you remember which 3.21 patch version you had? |
| I don't remember, unfortunately. |
Worked for me just now. Do you mind bumping it to that instead? |
| I just found some logs that showed my previous version was 3.21.4. I might try doing some testing to see what exactly was going on. I wonder if there was a regression in 3.21.4 |
| Was |
| Some test results: |
Could you also try |
| I'm actually getting different errors with that command. I'll keep poking around to see if I can narrow down what's truly the issue here. Thanks for helping me debug. I'll report back with any new findings. |
| I really appreciate the effort! Pinning down these nasty build errors is super helpful. |
Are all failing with the same error? The one from the forums thread? |
| Since 3.21.3 works for me but not Adam given the same checkout revision, I suspect it has something to do with the tools that ship with Xcode (I’ve got an older Xcode). The best we can do at this point is weed out the minimum version that cooperates with the latest Xcode release. |
| @aenewton Giving you a heads-up that |
| Hi @AnthonyLatsis thanks for the heads up. I haven't had time to dig in anymore and I'll continue to hold off. Is there a GitHub issue number I can follow for the current |
| I’m using #62205 to track it. |
| @LucianoPAlmeida Does CMake 3.22.2 work for you on macOS 13, or an older OS? |
Yeah, I'm on 13.0.1 (22A400) with Cmake 3.22.2 and up to beginning of the week it was all fine |
@aenewton By the way, was it a clean build each of those times? |
| Is this still viable? |
Yes, it started happening to me as well after updating to Xcode 14.x. I suggest we bump the CMake version to 3.22.2 for macOS + Xcode specifically until we crack the bug. @LucianoPAlmeida Are you running Xcode 14.x too? |
Sounds good
Yes, recently updated to 14.2 |
AnthonyLatsis left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aenewton Are you up for wrapping this up?
| @aenewton There is a conflict, so I think you have to rebase with main before we proceed with this =] |
| Don’t forget to squash the commits and update the commit message to reflect what we have settled on! |
Co-authored-by: Anthony Latsis <aqamoss3fan2010@gmail.com>
| Okay, I think it's ready now. Thanks for all the comments! |
| @swift-ci Please smoke test |
| @swift-ci Please smoke test Linux Platform |
| I just hit an issue after update-checkout today trying to run After updating to cmake to |
I’m still running an older CMake because I was hoping the look into the earlier issue. Any ideas as to what caused this? Any software updates? Which CMakeLists file is this error pointing at? |
Sorry, I didn't really investigate the issue, it initially looks like a recent change was using a variable that was not available in the cmake version(so I just updated). I can downgrade back and investigate further over the weekend.
Sorry, I don't remember seeing any. It just logged variables but I didn't search for them. I do remember thinking this was LLVM and not swift changes tho. |
The version of cmake currently listed in the docs is too low. It's possible that we could use a version somewhere between 3.19.6
and 3.24.3, but I chose the latest version that I tested successfully.
Resolves #62023