Remove is_unique invariant we don't guarantee #61791
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The invariant is checking if the "cached" isUniquelyReferenced result is still valid. The compiler can insert copies for lifetime adjustment during optimizations between the time isUniquelyReferenced is first "cached" to the invariant, such copies don't escape and don't really matter for COW. In such cases, this invariant will fire. This PR turns off this invariant. rdar://100530373
Contributor Author
| I don't have a unit test for this. This was firing in a few sodlib tests in our repository on certain Linux configurations. |
Contributor Author
| @swift-ci smoke test |
eeckstein requested changes Oct 31, 2022
Contributor
eeckstein left a comment
eeckstein left a comment There was a problem hiding this comment.
Basically LGTM.
But this should also be removed in ContiguousArray and in Array/ContiguousArray::_reserveCapacityImpl
Contributor Author
| I am going to close this PR and address the underlying reason here - #61826 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The invariant is checking if the "cached"
isUniquelyReferencedresult is still valid. The compiler can insert copies for lifetime adjustment during optimizations between the timeisUniquelyReferencedis first "cached" to the invariant, such copies don't escape and don't really matter for COW. In such cases, this invariant will fire.This PR turns off this invariant.
rdar://100530373