Add an option to build the concurrency library for back deployment. #39051
+335 −33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member Author
| @swift-ci please test |
Contributor
| Build failed |
Contributor
| Build failed |
Member Author
| @swift-ci please test |
Member Author
| @swift-ci please build toolchain |
Contributor
| macOS Toolchain Install command |
DougGregor force-pushed the concurrency-back-deploy-libraries branch from 78996a3 to 507d4d4 Compare Member Author
| @swift-ci please smoke test |
Introduce an additional build product to build-script to build back-deployable concurrency libraries. These libraries would need to be embedded in apps deployed prior to macOS 12/iOS 15 to support concurrency. The built-script option `--back-deploy-concurrency` can be provided to build these back-deployment libraries. They are built in addition to the normal concurrency libraries, as a separate product that installs into `lib/swift-5.5/<platform>` within the toolchain. The macro `SWIFT_CONCURRENCY_BACK_DEPLOYMENT` is set when building the concurrency library, so that we can adapt the implementation to older OS's.
…yment. When enabling the build of the back-deployable concurrency library via the build-script option `--back-deploy-concurrency`, also build the compiler and (main) concurrency library to support older deployment targets. Building the compiler for older deployment targets is effectively the same as implicitly passing `-Xfrontend -enable-experimental-back-deploy-concurrency`. That option should probably go away. Building the primary _Concurrency library for back-deployment means setting the "SwiftStdlib 5.5" availability back to the earlier deployment targets. This should have no effect on how the _Concurrency library binary is built, but it does ensure that the right availability annotations are in the _Concurrency module.
…ncy. When build-script is given `--back-deploy-concurrency`, also use that to build other parts of Swift with the back-deployed versions: * The compiler allows async and actors to be defined with the back-deployed availability, e.g., the same as `-Xfrontend -enable-experimental-back-deploy-concurrency`. (The latter will go away soon) * The standard library unit testing framework and distributed actors library are build with the older OS versions. * The tests use the older OS versions, with some adjustments to make them agnostic to the back-deployment setting.
DougGregor force-pushed the concurrency-back-deploy-libraries branch from 507d4d4 to ebd7b49 Compare Member Author
| @swift-ci please test |
| Will this work with XCFrameworks as well? Will the library be included in the distributed frameworks? |
| @swift-ci please build toolchain |
| Is there a toolchain build, or is it planned to be included in the future Xcode versions? |
| Is there any way to make it work on iOS 12 as well? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Introduce an additional build product to build-script to build
back-deployable concurrency libraries. These libraries would need to
be embedded in apps deployed prior to macOS 12/iOS 15 to support
concurrency.
The built-script option
--back-deploy-concurrencycan be provided tobuild these back-deployment libraries. They are built in addition to
the normal concurrency libraries, as a separate product that installs
into
lib/swift-5.5/<platform>within the toolchain. The macroSWIFT_CONCURRENCY_BACK_DEPLOYMENTis set when building theconcurrency library, so that we can adapt the implementation to older
OS's.
When building the back-deployment libraries, the compiler will
accept async functions and actors with earlier deployment
targets. In this case, the modules themselves will reflect the
earlier availability. Testing has been updated to work in
either configuration.