[Driver][Index] Add driver support to specify an overriding output path to record in the index data #36272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| @swift-ci please test |
Contributor
| Build failed |
Contributor
| Build failed |
Contributor Author
| @swift-ci please test |
nathawes force-pushed the update-driver-for-index-unit-output-path branch from c3c3ad4 to a669ab2 Compare Contributor Author
| @swift-ci please test |
nathawes force-pushed the update-driver-for-index-unit-output-path branch from a669ab2 to a39ec56 Compare Contributor Author
| @swift-ci please test |
nathawes force-pushed the update-driver-for-index-unit-output-path branch from a39ec56 to 701bca4 Compare Contributor Author
| @swift-ci please test |
Contributor Author
| @swift-ci please test Windows |
1 similar comment
Contributor Author
| @swift-ci please test Windows |
akyrtzi approved these changes Mar 5, 2021
nathawes force-pushed the update-driver-for-index-unit-output-path branch from 701bca4 to 348a2be Compare Contributor Author
| @swift-ci please test |
Contributor
| Build failed |
Contributor Author
| @swift-ci please smoke test Linux |
…th to record in the index data The frontend supports this via new options -index-unit-output-path and -index-unit-output-path-filelist that mirror -o and -output-filelist. These are intended to allow sharing index data across builds in separate directories (so different -o values) that are otherwise equivalent as far as the index data is concerned (e.g. an ASAN build and a non-ASAN build) by supplying the same -index-unit-output-path for both. This change updates the driver to add these new options to the frontend invocation 1) when a new "index-unit-output-path" entry is specified for one or more input files in the -output-file-map json or 2) if -index-file is specified, when a new -index-unit-output-path driver option is passed. Resolves rdar://problem/74816412
nathawes force-pushed the update-driver-for-index-unit-output-path branch from 348a2be to 117f03b Compare Contributor Author
| @swift-ci please test and merge |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The frontend supports this via new options -index-unit-output-path and -index-unit-output-path-filelist that mirror -o and -output-filelist. These are intended to allow sharing index data across builds in separate directories (so different -o values) that are otherwise equivalent as far as the index data is concerned (e.g. an ASAN build and a non-ASAN build) by supplying the same -index-unit-output-path for both.
This change updates the driver to add these new options to the frontend invocation 1) when a new "index-unit-output-path" entry is specified for one or more input files in the -output-file-map json or 2) when -index-file is specified (guaranteeing a single primary input) and a new -index-unit-output-path driver option is passed.
Equivalent change for the new driver here: swiftlang/swift-driver#516
Resolves rdar://problem/74816412