[stdlib][draft] Adds minmax() to Sequence, minIndex(), maxIndex(), minmaxIndices() to Collection #32784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
gribozavr added the swift evolution pending discussion 
gribozavr reviewed Jul 9, 2020
| let SequenceAlgorithmTests = TestSuite("SequenceAlgorithm") | ||
| | ||
| SequenceAlgorithmTests.test("[1,2,3,4,5,-9,6,7,8,9,0].min()") { | ||
| expectEqual([1,2,3,4,5,-9,6,7,8,9,0].min()!, -9) |
Contributor
There was a problem hiding this comment.
Please use OpaqueValue and MinimalComparableValue instead of integers.
Also, there are already tests for min and max in validation-test/stdlib/SequenceType.swift.gyb. Please add new tests there and follow the existing pattern.
stdlib/public/core/Collection.swift Outdated
| @warn_unqualified_access | ||
| public func minmaxIndices( | ||
| by areInIncreasingOrder: (Element, Element) throws -> Bool | ||
| ) rethrows -> (Index, Index)? { |
Contributor
There was a problem hiding this comment.
Would it be better if the elements of the result tuple were labelled? Please discuss this point in the proposal.
gribozavr reviewed Jul 15, 2020
| elements: test.sequence.enumerated().map { | ||
| MinimalComparableValue($1, identity: $0) | ||
| }) | ||
| var maybeResult = s.minmax() |
Contributor
There was a problem hiding this comment.
Thanks! what about other new APIs?
Member
This was referenced Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds minmax() to Sequence
Adds minIndex(), maxIndex(), minmaxIndices() to Collection
Adds minmax() to SIMDVector
Adds validation tests
Swift evolution proposal will be submitted soon.
Resolves SR-890 and SR-889.