[ownership] [sil-combine] update partial apply visitor to support ossa #30577
Conversation
| Also, I've made sure that the stdlib still builds when I move ownership elimination after silcombe in the pass pipeline. |
There was a problem hiding this comment.
Can you split out the hasOwnership move into its own commit? That way in this commit, you can show that you are removing the partial apply one? Then it is clear what the code motion is.
There was a problem hiding this comment.
I see that you actual did split it into two commits. Can you improve the commit message? Say what you are doing.
zoecarver force-pushed the ossa/sil-combine-partial-apply branch from f77cd0d to 04cb34d Compare | Ping. This is a test-only change. |
| Ah, apologies. @swift-ci test |
| Build failed |
| Somehow when I merged master into this I removed the sil combine change, so the tests are now failing. I'll add that back. Sorry for wasting the buildbot resources. @CodaFi thanks for the help. |
zoecarver force-pushed the ossa/sil-combine-partial-apply branch from 5346e03 to cf9755d Compare 
* No longer bail on ownership functions in the partial_apply visitor. * Add ossa versions of all partial_apply SILCombine sil tests.
zoecarver force-pushed the ossa/sil-combine-partial-apply branch from cf9755d to cb1529a Compare | @swift-ci please test |
| Build failed |
| Build failed |
| @swift-ci please test. (Just to make sure we're still OK.) |
| @swift-ci please test. |
| Build failed |
| Build failed |
5 participants
This patch updates the partial apply visitor in
SILCombineto support ownership. The visitor didn't need any changes but, I've added tests to make sure we support all non-ossa cases in ownership mode. Based on #30559.