[tools] Add include path for iconv on OpenBSD. #30561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
3405691582 force-pushed the OpenBSD_Iconv_AdditionalIncludePath branch from d6c7ba6 to 7bf1488 Compare 
compnerd requested changes Mar 24, 2020
swift-ide-test depends on libxml2. On OpenBSD, libxml2 is configured to use iconv out of the box, but unlike other platforms, iconv is not part of the base installation; it is a separate package, and so resides in /usr/local/include. This should be added to the search path on this platform to ensure correct header resolution.
3405691582 force-pushed the OpenBSD_Iconv_AdditionalIncludePath branch from 7bf1488 to c9098c6 Compare 
Member
| @swift-ci please test |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
swift-ide-test depends on libxml2. On OpenBSD, libxml2 is configured to use
iconv out of the box, but unlike other platforms, iconv is not part of
the base installation; it is a separate package, and so resides in
/usr/local/include. This should be added to the search path on this
platform to ensure correct header resolution.