lit.cfg: move the DYLD_LIBRARY_PATH setting code to the config.substitutions #24003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…tutions This change the order the configuration file to something that makes more sense: the platform_module_dir value was being set in the middle of the config.substitutions phase. We needed said value for setting the DYLD_LIBRARY_PATH, so that code was added right after it. The problem is that by that time config.substitutions.append(('%target-run', config.target_run)) has already happened for local targets This change moves all said code to just before the substitutions phase, much cleaner and resolves rdar://problem/49835064 
shajrawi force-pushed the cherry_51_lit_bugfix branch from ccaf733 to 0184544 Compare 
shajrawi force-pushed the cherry_51_lit_bugfix branch from c34ce6c to 0184544 Compare 
Author
| @swift-ci Please test and merge |
Contributor
| Build failed |
Author
| @swift-ci Please test Linux |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
cherry-pick #23996 to 5.1 branch
rdar://problem/49835064