Set up testing with the standard libraries coming from the OS #23583
Conversation
| @shahmishal Can you please review? |
shajrawi force-pushed the testing_os branch 2 times, most recently from 07fa00c to 0134861 Compare | @swift-ci Please test |
test/lit.cfg Outdated
There was a problem hiding this comment.
I don't quite get this part. For remote runs, you'd have to not provide REMOTE_RUN_CHILD_DYLD_LIBRARY_PATH to get it to use the OS libraries, right?
There was a problem hiding this comment.
For remote runs, REMOTE_RUN_CHILD_DYLD_LIBRARY_PATH is all that matters - you can choose between the OS libraries and the just-built libraries by passing a different remote_tmp_dir parameter - you get to choose between the two options today. this new PR is for supporting said choice on a local target
There was a problem hiding this comment.
That's not correct. remote_tmp_dir is for uploads; you can't set it to /usr/lib/swift and have things work out. You'll need to honor this new option there too.
There was a problem hiding this comment.
ah, you're right, updated the PR accordingly.
| Changed the PR to have the just-built libraries in the |
shajrawi force-pushed the testing_os branch 2 times, most recently from c1f576e to 54254d0 Compare | @swift-ci Please smoke test |
test/lit.cfg Outdated
There was a problem hiding this comment.
Some tabs snuck in here.
There was a problem hiding this comment.
whoops - accidentally missed the branch up when trying to fix the tab - sorry - will re-open a PR
2 participants
We default Swift tests to use the just-built libraries
See radars rdar://problem/35163663 and rdar://problem/42176864