Skip to content

Fix SR-8570 by allowing existential metatypes for empty type-list attributes #18907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2018
Merged

Fix SR-8570 by allowing existential metatypes for empty type-list attributes #18907

merged 1 commit into from
Aug 22, 2018

Conversation

@lattner
Copy link
Contributor

@lattner lattner commented Aug 22, 2018

Fix SR-8570 by allowing existential metatypes for empty type-list attributes.
@lattner lattner added the tensorflow This is for "tensorflow" branch PRs. label Aug 22, 2018
@lattner lattner requested review from bgogul and rxwei August 22, 2018 20:40
@lattner
Copy link
Contributor Author

lattner commented Aug 22, 2018

@swift-ci please test tensorflow
rxwei
rxwei approved these changes Aug 22, 2018
View reviewed changes
Copy link
Contributor

@rxwei rxwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, @m3bm3b was just about to fix this.
@lattner lattner merged commit 7036a35 into tensorflow Aug 22, 2018
@lattner
Copy link
Contributor Author

lattner commented Aug 22, 2018

Ah, sorry @m3bm3b, I didn't mean to conflict with your work.
@compnerd compnerd deleted the typelist-existential branch May 31, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tensorflow This is for "tensorflow" branch PRs.

4 participants

@lattner @rxwei @bgogul