Turn on formation of Const graph_op's in deabstraction even for the non-strict-deabstraction case #18020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
non-strict-deabstraction case.
Contributor Author
| @swift-ci please test tensorflow |
Contributor Author
| I expect this to fail a bunch of testcases, I'll iterate here in the PR and request review when I converge. |
file now blocking the other issues from being reported in partitioning, so move that test to the right file.
Contributor Author
| @swift-ci please test tensorflow |
1 similar comment
Contributor Author
| @swift-ci please test tensorflow |
rxwei approved these changes Jul 17, 2018
Contributor Author
| @swift-ci please test tensorflow |
2 similar comments
Contributor Author
| @swift-ci please test tensorflow |
Contributor Author
| @swift-ci please test tensorflow |
mhong approved these changes Jul 17, 2018
| | ||
| public func shapeError() { | ||
| // expected-error @+1 {{tensor literal should have 9 scalars for this shape, but has 8}} | ||
| let _ = Tensor<Float>(shape: [1, 3, 3, 1], |
There was a problem hiding this comment.
the 9 in "tensor literal should have 9 scalars for this shape" could be a bit confusing -- do we want to give more context on what the extra scalar is -- is that the meta type?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This will start producing graph_op in more cases, and inches towards strict deabstraction being on by default.
This will mostly be about updating testcases, which I'll iterate in the PR.