Start refactoring bits of deabstraction #18010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- introduce a new pass to clean up instructions instead of having all the transformations do it. This needs to be generalized, but is a start. This should improve compile time when strict deabstraction is on. - Refactor a bunch of code into a "createConstTensor" helper in TFUtilities. It would be nice for the rest of the compiler that produces "Const" nodes to start using this. The patch to SILType.h has been sent upstream in PR18003 so it has no SWIFT_ENABLE_TENSORFLOW marker.
Contributor Author
| @swift-ci please test tensorflow |
mhong approved these changes Jul 17, 2018
| // All graph_op's get a device. | ||
| attributes.push_back({ | ||
| context.getIdentifier(DEVICE_ATTR), | ||
| SymbolicValue::getString(getDeviceString(deviceConfig.primaryDeviceType), |
Contributor Author
There was a problem hiding this comment.
This is intended to be usable by multiple clients. Hard coding ALL_DEVICES doesn't seem general... wouldn't that prevent it from being useful to lowerGraph and other things that need it?
Contributor Author
There was a problem hiding this comment.
We chatted, I know what to do :-)
rxwei approved these changes Jul 17, 2018
Contributor Author
| @swift-ci please test and merge tensorflow |
Contributor Author
| @swift-ci please test tensorflow and merge |
Contributor Author
| @swift-ci please test tensorflow |
1 similar comment
Contributor Author
| @swift-ci please test tensorflow |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
all the transformations do it. This needs to be generalized, but is
a start. This should improve compile time when strict deabstraction
is on.
TFUtilities. It would be nice for the rest of the compiler that
produces "Const" nodes to start using this.
The patch to SILType.h has been sent upstream in PR18003 so it has no
SWIFT_ENABLE_TENSORFLOW marker.