[Migrator] Apply fixit coercing IUO to Any #16451
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member Author
| @swift-ci Please smoke test |
rudkx requested changes May 8, 2018
| void emitSilenceOptionalAnyWarningWithCoercion(Expr *E, Type destType) { | ||
| Diag<Type, StringRef> silenceDiag = diag::silence_optional_to_any; | ||
| | ||
| if (auto declRefExpr = dyn_cast<DeclRefExpr>(E)) { |
Contributor
There was a problem hiding this comment.
You should use hasImplicitlyUnwrappedResult which I added in #16434.
I handles function calls, subscripts, and member references.
| let _: Any = x | ||
| | ||
| let y: Int? = 1 | ||
| let _: Any = y |
Contributor
There was a problem hiding this comment.
Please add tests for member references, function calls, subscripts, as well a test where the code already has 'as Any' (and thus we wouldn't expect the note, nor the migration).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR makes the migrator automatically add
as Anycoercions when the base type is an implicitly unwrapped optional.Fixes rdar://40050875