[TestingMacros] Remove reference to implicit backtracing import. #921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The _Backtracing module was never implicitly imported by default, so this wasn't necessary anyway, but adding it is a blocker for SE-0419. rdar://143310300
al45tair requested review from SeanROlszewski, briancroom, grynspan, stmontgomery and suzannaratcliff as code owners 
grynspan approved these changes Jan 21, 2025
I think this was the only reference I could find. I only went looking after my Windows build kept unexpectedly failing because of something using this option. |
| I suppose I'm curious why this caused a failure. |
| @swift-ci test |
To be fair, I don't know that it's specifically this that's causing the failure, but something is passing the |
| @swift-ci test macOS |
| CI is still down, I think. Please do not merge until all three jobs have completed successfully. Thanks! |
| @swift-ci test |
stmontgomery approved these changes Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The
_Backtracingmodule was never implicitly imported by default, so this wasn't necessary anyway, but adding it is a blocker for SE-0419.rdar://143310300