Don't use @_semantics, use our own attribute instead. #874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
grynspan requested review from SeanROlszewski, briancroom, dennisweissmann, stmontgomery and suzannaratcliff as code owners 
| @swift-ci test |
grynspan force-pushed the jgrynspan/dont-use-@_semantics branch from 486b79b to 53893cd Compare | @swift-ci test |
This PR replaces our use of `@_semantics` with a custom attribute macro. `@_semantics` is reserved for use by the standard library and runtime and, while useful, can be emulated on our side of the module barrier without much difficulty. Note there are no unit tests for this macro: it doesn't actually _do_ anything on its own!
grynspan force-pushed the jgrynspan/dont-use-@_semantics branch from 0cc9224 to e24030d Compare | @swift-ci test |
| @swift-ci test |
stmontgomery approved these changes Dec 20, 2024
Co-authored-by: Stuart Montgomery <smontgomery@apple.com>
| @swift-ci test |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR replaces our use of
@_semanticswith a custom attribute macro.@_semanticsis reserved for use by the standard library and runtime and, while useful, can be emulated on our side of the module barrier without much difficulty.Checklist: