Add @_spi annotations to reexport decls in cross-import overlays. #870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This PR attempts to make sure that SPI is reexported from our cross-import overlays. This change is speculative and I'm not actually sure if it'll do what I want.
grynspan added bug grynspan requested review from SeanROlszewski, briancroom, dennisweissmann, stmontgomery and suzannaratcliff as code owners 
| @swift-ci test |
| @swift-ci test Linux |
stmontgomery approved these changes Dec 20, 2024
| @xedin What about this change? It was experimental—but if Vapor is importing Testing and Foundation, perhaps this change hit a corner of cross-import overlays that isn't fully functional? |
grynspan added the cross-import-overlays Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR attempts to make sure that SPI is reexported from our cross-import overlays. This change is speculative and I'm not actually sure if it'll do what I want.
Checklist: