Skip to content

Conversation

stmontgomery
Copy link
Contributor

This is a minor refactor of the logic and data structures in the @Test macro implementation responsible for parsing and handling test function argument expressions.

Motivation:

I discovered there was a way to simplify this logic while working on #808, and since this isn't strictly pertinent to that PR I wanted to extract it and land it separately here.

Modifications:

  • Remove the need to hardcode the parameter label arguments: in three places.
  • Remove the need to iterate a Collection using raw indices.
  • Resolve one "TODO" comment.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.
@stmontgomery stmontgomery force-pushed the test-args-attr-discovery branch from 7460fce to 77c469b Compare November 22, 2024 21:38
@stmontgomery
Copy link
Contributor Author

@swift-ci please test

@stmontgomery
Copy link
Contributor Author

@swift-ci please test

@stmontgomery stmontgomery merged commit 0098422 into swiftlang:main Dec 10, 2024
3 checks passed
@stmontgomery stmontgomery deleted the test-args-attr-discovery branch December 10, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

2 participants