Set RLIMIT_CORE=1 instead of =0 on Linux. #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The Linux kernel special-cases `RLIMIT_CORE=1` to mean "no, really, don't write a core file even if it'd be to a pipe." Which sounds like a niche use case but Ubuntu 24 by default enables Apport for crash reporting and Apport works by setting the core pattern to write to a pipe. This resolves a performance issue on Linux where exit tests would always take almost exactly one second instead of a few microseconds (unless you explicitly turned off Apport.)
grynspan added bug grynspan requested review from SeanROlszewski, briancroom, dennisweissmann, stmontgomery and suzannaratcliff as code owners 
| @swift-ci test |
stmontgomery approved these changes Sep 27, 2024
| @swift-ci test Windows |
1 similar comment
| @swift-ci test Windows |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The Linux kernel special-cases
RLIMIT_CORE=1to mean "no, really, don't write a core file even if it'd be to a pipe." Which sounds like a niche use case but Ubuntu 24 by default enables Apport for crash reporting and Apport works by setting the core pattern to write to a pipe.This resolves a performance issue on Linux where exit tests would always take almost exactly one second instead of a few microseconds (unless you explicitly turned off Apport.
Checklist: