Special-case comparisons of ranges in __checkBinaryOperation(). #640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
grynspan requested review from SeanROlszewski, briancroom, dennisweissmann, stmontgomery and suzannaratcliff as code owners 
| @swift-ci test |
This PR adds an overload of `__checkBinaryOperation()` that is used when the inputs are range expressions. Ranges do not play well with collection diffing so we want to disable that functionality for them. Resolves #639. Resolves rdar://131122002. Co-authored-by: @ricky-sharp
grynspan force-pushed the jgrynspan/131122002-range-diffing-hang branch from 2e2b210 to 4e35ff1 Compare | @swift-ci test |
| Thank you again so much for identifying the issue so quickly and generating this fix! |
briancroom approved these changes Aug 23, 2024
suzannaratcliff approved these changes Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR adds an overload of
__checkBinaryOperation()that is used when the inputs are range expressions. Ranges do not play well with collection diffing so we want to disable that functionality for them.Resolves #639.
Resolves rdar://131122002.
Checklist: