[CMake/Macros] Set correct RPATH #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
It's not guaranteed that the host compiler has all the dependency loaded.
Other macro libraries e.g. ObservationMacros don't import them.
rintaro requested review from SeanROlszewski, briancroom, dennisweissmann, grynspan, stmontgomery and suzannaratcliff as code owners 
| @swift-ci Please test |
grynspan approved these changes Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Previously it expected the host (i.e. the compiler) already loaded all dependencies in the process. But since that's not guaranteed, let's set the correct RPATH.
Also, stop importing string-processing and backtracing.