Skip to content

Conversation

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek
Copy link
Contributor Author

@swift-ci please test

/// swift repo, and breaking clients with the new addition to the protocol.
extension BuildConfiguration {
/// FIXME: This should be @_spi(ExperimentalLanguageFeatures) but cannot due
/// to rdar://147943518, https://github.com/swiftlang/swift/issues/80313
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this FIXME is no longer relevant now, right?

Also, could you mark this default implementation as deprecated so that clients conforming to BuildConfiguration without implementing isActiveTargetObjectFormat get a warning, similar to what we do in

@available(*, deprecated, message: "`MacroExpansionContext` conformance must implement `lexicalContext`")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants