Add support for borrow and mutate accessors #3150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
meg-gupta requested review from ahoppen, bnbarham, hamishknight and rintaro as code owners 
| @swift-ci test |
ahoppen reviewed Sep 10, 2025
| var _otherK: Klass | ||
| var k1: Klass { | ||
| borrow { |
There was a problem hiding this comment.
I just want to mention that this will be source breaking for the following code, which is currently valid. I’ll leave it up to you to decide whether that source breakage is acceptable.
func borrow<T>(_ x: () -> T) -> T { return x() } var x: Int { borrow { 1 } }There was a problem hiding this comment.
Thanks for pointing that out. This is currently experimental and is not an immediate problem. We may gate the feature on language version in the future if source breakage becomes a concern.
meg-gupta force-pushed the borrowandmutateaccessors branch from 9af2aaa to d165336 Compare | @swift-ci test |
| @swift-ci smoke test |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add support for borrow and mutate accessors in the swift parser.