- Notifications
You must be signed in to change notification settings - Fork 459
fixed-typed-throws-after-arrow-fixit #2731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed-typed-throws-after-arrow-fixit #2731
Conversation
7523e31
to c8f261a
Compare c8f261a
to 2c2c810
Compare 2c2c810
to 37be3b4
Compare 07a7053
to e6cf861
Compare e6cf861
to a3f776e
Compare a3f776e
to 2976fc0
Compare @ahoppen, could you review my latest commit? :) |
Did you try to address #2731 (comment)? |
I might have tried that but now I've forgotten it ;) |
2976fc0
to 1981651
Compare #2731 (comment) addressed. |
1981651
to c853e3b
Compare @swift-ci Please test |
@swift-ci Please test Windows |
1 similar comment
@swift-ci Please test Windows |
- `Parser.parseMisplacedEffectSpecifiers` will detect whether there is any misplaced typed throws. If yes, it will try to parse the thrown type and mark all tokens of the thrown type as missing. - `ParseDiagnosticsGenerator.handleMisplacedEffectSpecifiersAfterArrow` will recognize the entire throws clause as correct instead of the throws specifier only. - `ParseDiagnosticsGenerator.exchangeNodes` to replace `ParseDiagnosticsGenerator.exchangeTokens`, relaxing the input type from token to any syntax node. - refactored `TokenMissingMaker` in Declaration.swift, moved to Parser.swift, creating `Parser.withAllTokensMarkedMissing` for more generalized use.
Head branch was pushed to by a user without write access
c853e3b
to c225440
Compare Fixed, please test again. |
@swift-ci Please test |
@swift-ci Please test macOS |
@swift-ci Please test Windows |
fixes #2391