[SyntaxText] Always use memcmp #2617
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @swift-ci Please test |
rintaro commented Apr 22, 2024
| #elseif canImport(Glibc) | ||
| import Glibc | ||
| #elseif canImport(Musl) | ||
| import Musl |
There was a problem hiding this comment.
In case anyone is wondering if Musl has memcmp: http://git.musl-libc.org/cgit/musl/tree/include/string.h#n30 http://git.musl-libc.org/cgit/musl/tree/src/string/memcmp.c
| 🤔 https://ci.swift.org/job/swift-syntax-PR-macOS/4092/ |
| @swift-ci Please test macOS |
| @swift-ci Please test |
| @swift-ci Please test Windows |
ahoppen approved these changes Apr 22, 2024
| Windows failure is probably because |
| @swift-ci Please test |
| @swift-ci Please test |
| @swift-ci Please test Windows |
`compareMemory(_:_:_:)` was to abstract `memcmp` or `Collection.elementsEqual(_:)` depending on the platform or build settings. Now that we consistently imports "platform" system module, so `memcmp` is reliably available.
| swiftlang/swift#73224 |
| swiftlang/swift#73224 |
2 similar comments
| swiftlang/swift#73224 |
| swiftlang/swift#73224 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
compareMemory(_:_:_:)was to abstractmemcmporCollection.elementsEqual(_:)depending on the platform or build settings. Now that we consistently imports "platform" system module, somemcmpis reliably available.