Skip to content

[5.10] Change load to loadUnaligned #2534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2024
Merged

[5.10] Change load to loadUnaligned #2534

merged 1 commit into from
Mar 8, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Mar 7, 2024

  • Explanation: Same fix as load => loadUnaligned swift-package-manager#6929 since the code in swift-syntax is based on what is in SwiftPM. We cherry-picked this from main to package-release/509 but forgot to cherry-pick it to release/5.10
  • Scope: This causes macro plugin crashes on Linux
  • Risk: Low, we have had this change in the 509 release of swift-syntax and on main, just not on release/5.10
  • Testing: We verified that this change fixed the issue in the 509 release and on main, it’s just missing on release/5.10
  • Issue: n/a
  • Reviewer: @bnbarham and @rintaro on load => loadUnaligned #2312
@neonichu @ahoppen
load => loadUnaligned
d44705d 
Same fix as swiftlang/swift-package-manager#6929 since the code in swift-syntax is based on what is in SwiftPM.
@ahoppen
Copy link
Member Author

ahoppen commented Mar 7, 2024

@swift-ci Please test
rintaro
rintaro approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@rintaro rintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you🙏
@ahoppen
Copy link
Member Author

ahoppen commented Mar 7, 2024

@swift-ci Please test Windows
@ahoppen ahoppen merged commit fa8f95c into swiftlang:release/5.10 Mar 8, 2024
@ahoppen ahoppen deleted the ahoppen/5.10/unaligned-load branch March 8, 2024 23:45
@vanvoorden
Copy link 

Swift/UnsafeRawPointer.swift:440: Fatal error: load from misaligned raw pointer

Here is an extra breadcrumb trail if anyone else stumbles on this error building 510.0.0 on Linux.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants

@ahoppen @vanvoorden @rintaro @bnbarham @airspeedswift @neonichu