Add whitespace if needed when returning syntaxTextBytes #2110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
TTOzzi force-pushed the fix-syntax-text-bytes branch 2 times, most recently from f54f613 to d66cdc5 Compare 
TTOzzi force-pushed the fix-syntax-text-bytes branch from d66cdc5 to e707e00 Compare 
ahoppen requested changes Aug 28, 2023
There was a problem hiding this comment.
This is not correct because it breaks round-tripness of the syntax tree. If you generate source code, parse it and print the syntax tree, it must exactly correspond to the original source tree.
With this change a space that wasn’t present in the original source is added during the printing, which breaks this property.
As I commented in #2107, I think the fix for that issue is a lot more involved.
| From the comments you left on the issue, I understand that it's much more difficult than I realized to fix the issue without modifications to the original source. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Resolve #2107
While it's not a problem if different kinds of tokens that can be distinguished by their kinds appear consecutively without whitespace; however, if tokens of the same kind are positioned without a delimiter, there arises an issue when converting syntaxTextBytes into a SyntaxNode.
When two indistinguishable(of the same kind) tokens are positioned consecutively without whitespace or punctuation, I have added whitespace for differentiation.