Introduce SyntaxVisitorBase #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nkcsgexi approved these changes Jul 8, 2019
This is useful if you intend to have subclasses overriding specific methods of a common base `SyntaxVisitor` class.
akyrtzi force-pushed the syntaxvisitorclass branch from fc72f76 to ee7123b Compare 
| @swift-ci Please test |
adevress pushed a commit to adevress/swift-syntax that referenced this pull request Jan 14, 2024
[NFC] Remove links to Google's style guide in comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is useful if you intend to have subclasses overriding specific methods of a common base
SyntaxVisitorclass.It workarounds the issue of not being able to override the default implementations of the protocol (see https://bugs.swift.org/browse/SR-103).