Merge timedOut with softTimeout #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Remove `softTimeout` since timeouts are no longer reported as issues, and make `timedOut` a soft error since faster runs could hit issues that aren't hit if they happen to timeout.
| @swift-ci please test |
ahoppen approved these changes Mar 8, 2025
Comment on lines +58 to +60
| /// The current use case for soft errors are timeouts, since it's possible | ||
| /// that it hits a failure on a faster run, which can lead to non-determinism | ||
| /// in matching XFAILs. |
There was a problem hiding this comment.
This comment is out-of-date now, right?
There was a problem hiding this comment.
We still need soft errors for proper timeouts, since on faster runs a request can hit an error, and on slower runs they can hit a timeout. The current stress tester failure is because we have requests timing out, but sometimes they are able to finish and instead hit a known issue. So we need to have timeouts be able to match XFAILs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Remove
softTimeoutsince timeouts are no longer reported as issues, and maketimedOuta soft error since faster runs could hit issues that aren't hit if they happen to timeout.