Skip to content

Add compiler and linker options for wasm32-wasip1-threads #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2024
Merged

Add compiler and linker options for wasm32-wasip1-threads #104

merged 1 commit into from
Apr 18, 2024

Conversation

kateinoigakukun
Copy link
Member

Those options must be passed for -threads targets
@kateinoigakukun
Copy link
Member Author

@swift-ci test
@kateinoigakukun
Copy link
Member Author

@swift-ci test macOS
@kateinoigakukun kateinoigakukun marked this pull request as ready for review April 18, 2024 10:26
@MaxDesiatov
Copy link
Contributor

Is it possible to add some test coverage to verify that generated flags match our expectations?
@kateinoigakukun
Copy link
Member Author

@swift-ci test
MaxDesiatov
MaxDesiatov approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@kateinoigakukun
Copy link
Member Author

@swift-ci test macOS
@kateinoigakukun kateinoigakukun merged commit 966e011 into swiftlang:main Apr 18, 2024
@kateinoigakukun kateinoigakukun deleted the yt/threads-options branch April 18, 2024 11:17
@kateinoigakukun kateinoigakukun mentioned this pull request Apr 26, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@kateinoigakukun @MaxDesiatov