swift package --help doesn't show subcommands provided by plugins #9284
+243 −40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
johnbute requested review from bkhouri, bripeticca, cmcgee1024, daveyc123, dschaefer2, jakepetroules, owenv, plemarquand, rconnell9 and shawnhyam as code owners …e --help causes bug where --help is not recognized by subcommands
johnbute requested review from AnthonyLatsis, bnbarham and xedin as code owners | @swift-ci please test |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Modified swift package --help in order to include possible commands provided by command plugins
Motivation:
Fixes #9226
Modifications:
Overrode --help and -h of swift package command to also include, after printing the help message, the output of swift package plugin --list
Added tests to support change too
Result:
After --help message is printed, users will see a new section (whenever needed) called AVAILABLE PLUGIN COMMANDS:
`
completion-tool Command to generate shell completions.
plugin Invoke a command plugin or perform other actions on command plugins.
See 'swift help package ' for detailed help.
AVAILABLE PLUGIN COMMANDS:
benchmark (plugin ‘BenchmarkCommandPlugin’ in package ‘Benchmark’)
`