[WIP] Dynamically generate flag expectations in tests #5765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
compnerd reviewed Sep 10, 2022
Member
compnerd left a comment
compnerd left a comment There was a problem hiding this comment.
This seems to be going in the right direction. I wonder if we can now share some of the platform agnostic flags, extending that set for the comparison as necessary, assuming that the differences are all suffixed rather than infixed. If not, that is okay, but the more that can be shared, the better we are.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #5474.
Run build tests on all platforms regardless of the host platform.
Motivation:
As @compnerd pointed out in the initial ticket, many of the tests in are currently statically generating the flags for expectations in
BuildPlanTests.swiftbased upon#if oswhich changes behavior based on the OS rather than the target. This can cause subtle bugs to arise. We should dynamically compute the arguments.Modifications:
Removed compile time constants from
BuildPlanTests.swiftand added tests for all supported destinations.Result:
Most tests in
BuildPlanTests.swiftwill test Windows, Linux, and Android compiler flags even when tests are running on macOS, and vice-versa.