Revert "Add nuget package provider" #5742
Open
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Reverts #5486
NuGet is being excessively used to support C# and .NET on multiple platforms, but SwiftPM can hardly consume its package in practice. NuGet works in a totally different way from the other package managers we supported before.
nuget installyou're actually downloading the packages into current working directory. The behavior diverges with the SwiftPM warning.Additionally, even if NuGet is said to support "native packages", these packages are not always vendored by trustable sources and only make up a small set of the packages. Microsoft has already introduced Vcpkg to handle C/C++ libraries, and its products are directly usable for SwiftPM. (Although @neonichu suggested that such support had better be implemented by a plugin, it seems impossible for now because binary and headers cannot be consumed.)
I'm going to close #4369 as not planned too.
@compnerd If your purpose is to pass the test suite on Windows, I would suggest adding a dummy provider for all platforms, instead of any exact one.