Adapt to mimalloc v3.0.1 #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
hjyamauchi force-pushed the mimallocv3.0.1 branch 4 times, most recently from 0ef105e to 786e66f Compare hjyamauchi force-pushed the mimallocv3.0.1 branch from 786e66f to 5f3c538 Compare hjyamauchi requested review from compnerd, etcwilde and shahmishal as code owners 
etcwilde reviewed Jan 28, 2025
Member
etcwilde left a comment
etcwilde left a comment There was a problem hiding this comment.
What are the licensing requirements for redistributing the mimalloc?
compnerd approved these changes Jan 29, 2025
Member
I believe that they are the same as zlib - it is a MIT licensed library and is permitted to be redistributed. |
Contributor Author
It's MIT license https://github.com/microsoft/mimalloc/blob/dev/LICENSE CC @compnerd |
Member
| I have to defer to @shahmishal in case we need to do something on the CI side. Otherwise, LGTM. |
etcwilde reviewed Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.